chore: upgrade to dbt 1.8 #614
Conversation
Jrmyy
force-pushed
the
chore-upgrade-to-dbt-1-8
branch
2 times, most recently
from
f2ccbac to
3c7e441
Compare
Jrmyy
force-pushed
the
chore-upgrade-to-dbt-1-8
branch
2 times, most recently
from
df9bd79 to
96d2e61
Compare
In DBT documentation, 2 owners are displayed: on the top line, we have the dbt owner as defined in the metadata, on the second line it is the owner of the sql representation of the model in Athena. But Athena does not support table owner except if used with LakeFormation. But in any case it is not an owner, in a traditional way as we can see it in Postgres. Since dbt 1.8 remove the ability to use the manifest object when retrieving catalog or schemas, we were forced to remove it. But it feels like we can remove it now because we have an owner displayed and the documentation and it reflects more what happened in reality.
Jrmyy
force-pushed
the
chore-upgrade-to-dbt-1-8
branch
from
98b1a9c to
85f7178
Compare
|
Overall looks good. dbt is still releasing new beta versions, see this https://github.com/dbt-labs/dbt-core/releases/tag/v1.8.0b2. My main question is: shall we consider to merge and release this and keep updating based on beta/final release? or we keep this open till the final release is reached? |
|
If we follow what other adapters did, they all merged and release beta versions, so we might want to also do that. It makes things trickier to deploy hotfixes (targeting commits or a v1.7 branch) but it will also let more time to stress test the beta version of production-grade projects |
|
Others adapters have people and resources to allocate to dbt. If we find time to keep up with the dbt 1.8 pre-, releases, I'm fine to merge it already. |
I believe we should create v1.7 branch as @Jrmyy mentioned to be able do hotfixes on previous dbt version. I'm not sure if other dbt-dependent projects will upgrade to 1.8 smoothly as well (like elementary) I've created |
|
@svdimchenko I don't see much sense of creating another branch tbh, as it will just create more extra work. The good part of 1.8,it is that we don't have to follow anymore dbt semantic library versioning. so we are starting to become free on the semantic library version of the adapter. Said so, I'm in favor of merging this, and do a release. cc @Jrmyy |
Description
Fixes #610
fix: remove table_owner retrieved from manifest
In DBT documentation, 2 owners are displayed: on the top line, we have the dbt owner as defined in the metadata, on the second line it is the owner of the sql representation of the model in Athena. But Athena does not support table owner except if used with LakeFormation. But in any case it is not an owner, in a traditional way as we can see it in Postgres. Since dbt 1.8 remove the ability to use the manifest object when retrieving catalog or schemas, we were forced to remove it. But it feels like we can remove it now because we have an owner displayed and the documentation and it reflects more what happened in reality.
Checklist